Skip to content

add paths section to kubelet statusz endpoint #133239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add paths section to kubelet statusz endpoint #133239

wants to merge 1 commit into from

Conversation

Peac36
Copy link
Contributor

@Peac36 Peac36 commented Jul 27, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Fix #133184

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add paths section to kubelet statusz endpoint

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Example response:

kubelet statusz
Warning: This endpoint is not meant to be machine parseable, has no formatting compatibility guarantees and is for debugging purposes only.

Started:  Sat Aug  2 13:38:51 UTC 2025
Up:  0 hr 00 min 07 sec
Go version:  go1.24.0
Binary version:  1.34
Emulation version:  1.34
Paths:   /configz /debug /healthz /metrics

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 27, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Peac36. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Peac36
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from kannon92 and mtaufen July 27, 2025 11:12
@Peac36
Copy link
Contributor Author

Peac36 commented Jul 27, 2025

cc @richabanker

@Peac36 Peac36 changed the title dd paths section to kubelet statusz endpoint add paths section to kubelet statusz endpoint Jul 27, 2025
@Peac36
Copy link
Contributor Author

Peac36 commented Aug 2, 2025

@richabanker - I've updated the description with the example response from the kubelet, similarly to the previous PR.

@richabanker richabanker mentioned this pull request Aug 5, 2025
Open
@richabanker
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2025
richabanker
richabanker reviewed Aug 5, 2025
View reviewed changes
pkg/kubelet/server/server.go
@@ -379,6 +382,13 @@ func (s *Server) InstallTracingFilter(tp oteltrace.TracerProvider, opts ...otelr
s.restfulCont.Filter(otelrestful.OTelFilter("kubelet", append(opts, otelrestful.WithTracerProvider(tp))...))
}

func (s *Server) InstallStatusZ() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un-export this since its only used here?

Copy link
Contributor Author

@Peac36 Peac36 Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all other Install like methods are exported, but used only here, does it make sense to make only this one not exported?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, we can export it later if the need arises..

@richabanker richabanker mentioned this pull request Aug 5, 2025
Open
@Peac36 Peac36 force-pushed the fix/133184 branch 2 times, most recently from fc05a42 to 59f8799 Compare August 5, 2025 17:20
@Peac36 Peac36 requested a review from richabanker August 5, 2025 18:17
@Peac36
Copy link
Contributor Author

Peac36 commented Aug 6, 2025

/test pull-kubernetes-unit-windows-master
/test pull-kubernetes-integration

@Peac36
add paths section to kubelet statusz endpoint
f2d5caf 
Signed-off-by: Nikola <peac36@abv.bg>
@richabanker
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

@Peac36: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows-master f2d5caf link false /test pull-kubernetes-unit-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@mtaufen mtaufen Awaiting requested review from mtaufen

@richabanker richabanker Awaiting requested review from richabanker

Assignees
No one assigned
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List available endpoints for kubelet's /statusz
3 participants
@Peac36 @k8s-ci-robot @richabanker