Skip to content

KEP-5278 Stop clearing NominatedNodeName in all cases #133276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2025
Merged

KEP-5278 Stop clearing NominatedNodeName in all cases #133276

merged 2 commits into from
Jul 29, 2025

Conversation

macsko
Copy link
Member

@macsko macsko commented Jul 29, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds removes NominatedNodeName clearing logic in case of scheduling failure.

This PR is co-authored by @utam0k

Which issue(s) this PR is related to:

Fixes: #132384
KEP: kubernetes/enhancements#5278

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The scheduler no longer clears the `nominatedNodeName` field for Pods. External components, such as Cluster Autoscaler and Karpenter, are responsible for managing this field when needed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 29, 2025
@macsko
Copy link
Member Author

macsko commented Jul 29, 2025

/cc @sanposhiho @utam0k

@k8s-ci-robot k8s-ci-robot added area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 29, 2025
@k8s-ci-robot k8s-ci-robot requested review from damemi and denkensk July 29, 2025 12:20
@macsko macsko force-pushed the stop_clearing_nnn_in_all_cases branch from 12707d7 to aea0a3c Compare July 29, 2025 12:21
@macsko
Copy link
Member Author

macsko commented Jul 29, 2025

/hold
For review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2025
macsko
macsko commented Jul 29, 2025
View reviewed changes
pkg/scheduler/schedule_one_test.go
}(),
// Depending on the timing, if asyncAPICallsEnabled, the NNN update might not be sent yet while checking the expectNominatedNodeName.
// So, asyncAPICallsEnabled is set to false.
asyncAPICallsEnabled: ptr.To(false),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status patch can be called after checking the expectNominatedNodeName. Currently, we skip these test cases.

sanposhiho
sanposhiho approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ed1ebf66d5ffbd1f3f0a148be8c38ba2e366786

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@utam0k
Copy link
Member

utam0k commented Jul 29, 2025

/lgtm

Thanks!

@macsko macsko mentioned this pull request Jul 29, 2025
Closed
@macsko
Copy link
Member Author

macsko commented Jul 29, 2025

/unhold
And wait for the milestone to be added.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2025
@Rajalakshmi-Girish
Copy link
Contributor

/milestone v1.34

@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 29, 2025
@macsko
Copy link
Member Author

macsko commented Jul 29, 2025

/retest

2 similar comments
@macsko
Copy link
Member Author

macsko commented Jul 29, 2025

/retest

@macsko
Copy link
Member Author

macsko commented Jul 29, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 74f7a44 into kubernetes:master Jul 29, 2025
13 checks passed
@jenshu jenshu mentioned this pull request Aug 1, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@utam0k utam0k Awaiting requested review from utam0k

@damemi damemi Awaiting requested review from damemi

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@utam0k utam0k

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
[sig-release] Bug Triage
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.

KEP-5278: Change the scheduler not to clear NNN
5 participants
@macsko @k8s-ci-robot @utam0k @Rajalakshmi-Girish @sanposhiho