node: unblock e2e serial lanes #133353
node: unblock e2e serial lanes #133353
Conversation
|
/test pull-kubernetes-node-kubelet-serial-containerd |
|
/test pull-kubernetes-e2e-gce |
|
/test pull-kubernetes-e2e-gce unrelated failure (flaky tests? can't look into them now) |
|
/test pull-kubernetes-node-swap-fedora-serial |
Skip problematic tests to recover signal, then we will reintroduce them gradually See: kubernetes#133314 See: kubernetes#133336 Signed-off-by: Francesco Romani <fromani@redhat.com>
daa674e to
aca402f
Compare
|
/test pull-kubernetes-node-kubelet-serial-containerd |
|
IIRC we recently switched machines for CI. This can be related, the memory manager settings are quite highly machine dependant. Let's see the new CI run |
|
/test pull-kubernetes-node-swap-fedora-serial |
|
/test pull-kubernetes-unit |
|
/triage accepted |
|
/milestone v1.34 |
|
Can you please add a # to the GitHub issue? It helps to link with the issue |
|
/test pull-kubernetes-node-swap-conformance-fedora-serial were other fixes merged elsewhere? The lanes seems to be improving |
|
cc @SergeyKanzhelev @haircommander @mrunalp It would be worth getting this in to help gain signal again in our serial test lanes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Presubmits are still failing even with this skip it looks like |
Yea, unforunely our serial tests have been failing for so long and we may have regressed. :( |
As you can see, this job has been failing for at least 3 weeks. So I still think we should merge this fix and then we can start looking into the other failures. |
I agree. Restoring some signal is better than no signal. I'm also working on long term fixes (no skips, no hacks) here: #133336 |
|
/milestone v1.34 These tests are making things very bad. We need a signal |
|
/unhold typo in #133353 (comment) |
|
@ffromani: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/skip |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
sig-node serial lanes are currently severely broken. We need to quickly restore signal.
Because of time pressure, disable problematic tests to recover signal.
By all means we will need to fix these tests once signal is restored, so this is a band-aid PR meant to fix the worst emergency, not the complete solution
Which issue(s) this PR is related to:
#133314
Special notes for your reviewer:
Will track long-term fixes editing this message
Does this PR introduce a user-facing change?