-
Notifications
You must be signed in to change notification settings - Fork 41.1k
reduced numPods to 5 from 10 to fix flaky test (supports reusing resources) due to timeout #133397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…urces) due to timeout.
We should identify the presubmit jobs this runs in and invoke them additional times after they complete with For the purposes of conformance, we should also still try to pick another test that is already proven to be stable, given the release is in ~3 weeks we do not have time to get 2 weeks of non-flaky results for this test to prove it is stable. Waiting for John & Patrick's feedback on the former, will continue that discussion in #133132. Thanks for working on fixing the flaky 🙏 |
/cc @dims IMHO this should be in scope for milestone as a test deflake, once sufficiently tested, but holding off for now. |
/test pull-kubernetes-kind-dra-all |
/retest |
the picked test to promote below is not flaky. the flaky test below is not promoted in PR #133132 |
/retest |
yes, discussing the other aspects back in that PR. pod timeout in a different test:
Let's make sure this change isn't flaky by testing it multiple times please, we usually do this with flake fixes, especially ones with arbitrary constants. /test all |
/retest |
just saw this flake in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/133431/pull-kubernetes-e2e-gce/1953575194064850944 ... is this fix intending to land for 1.34? |
Yes, it is intended for 1.34. It is a small fix. |
/triage accepted |
LGTM label has been added. Git tree hash: f6a497357e01e420f5748b4a94043b0f5e1916a6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
reduced numPods to 5 from 10 to fix flaky test (supports reusing resources) due to timeout
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: