e2e/watchlist: remove dynamic Age column value in Table test to prevent test flake
#133421
Conversation
|
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 7 08:56:53 UTC 2025. |
|
/assign @jpbetz |
|
fyi kind e2e tests are broken due to #133405 |
|
/retest |
|
/triage accepted |
| for i := range table.Rows { | ||
| cells := table.Rows[i].Cells | ||
| if ageColIndex < len(cells) { | ||
| cells[ageColIndex] = "" |
There was a problem hiding this comment.
Is this "normalizing" the age column, or is it "ignoring" it? It looks to me like it's ignoring it.
There was a problem hiding this comment.
good point, renamed to removeAgeColumnValueAtIndex, ptal
7faceaa to
7f44623
Compare
Age column in Table test to prevent test flakeAge column value in Table test to prevent test flake
|
LGTM label has been added. Git tree hash: 1ea3ed82da9fe31252455999e19716e62b95ccac
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
Agecolumn inmetav1.Tableis dynamic and reflects the time since object creation. In this test, expected comes from a GET and actual from a WATCH event. Since the GET call happens before the WATCH event is processed, theAgevalues can differ slightly (e.g.,0svs1s), leading to flaky comparisons.This PR cleans the
Agecolumn value for both sides.Tested on my local machine by running the flaky test 500 times.
Which issue(s) this PR is related to:
Fixes #133396
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: