Skip to content

Add e2e test for SELinuxMount to CSI drivers #133426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add e2e test for SELinuxMount to CSI drivers #133426

wants to merge 1 commit into from
+243 −0

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Aug 7, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add e2e tests that allow checking CSI drivers if they support SELinuxMount correctly or not.

  • Add a new seLinuxMount capability to the CSI driver test manifest
  • Add e2e tests that check the driver passes SELinux mount options when needed.

Which issue(s) this PR is related to:

Fixes N/A
KEP: kubernetes/enhancements#1710

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/1710

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.34 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.34.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 7 15:00:25 UTC 2025.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from gnufied and oomichi August 7, 2025 15:45
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign pohly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2025
@jsafrane
Copy link
Member Author

jsafrane commented Aug 7, 2025

/test pull-kubernetes-e2e-gce-storage-selinux
(We expect no regressions here. The new tests won't run, as the csi-driver-hostpath that we use in CI does not really support mounts with -o context)

@jsafrane jsafrane force-pushed the selinux-e2e-driver2 branch from 882444f to ad284d3 Compare August 8, 2025 08:33
@jsafrane
Copy link
Member Author

jsafrane commented Aug 8, 2025

/test pull-kubernetes-e2e-gce-storage-selinux
(We expect no regressions here. The new tests won't run, as the csi-driver-hostpath that we use in CI does not really support mounts with -o context)

@jsafrane
Copy link
Member Author

jsafrane commented Aug 8, 2025

/retest
scheduler + DRA flakes

@jsafrane jsafrane force-pushed the selinux-e2e-driver2 branch from ad284d3 to 1ea4720 Compare August 8, 2025 12:25
@jsafrane
Copy link
Member Author

jsafrane commented Aug 8, 2025

/test pull-kubernetes-e2e-gce-storage-selinux

@jsafrane
Copy link
Member Author

/retest

1 similar comment
@jsafrane
Copy link
Member Author

/retest

@jsafrane
Copy link
Member Author

/test pull-kubernetes-e2e-gce-storage-selinux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@oomichi oomichi Awaiting requested review from oomichi

Assignees
No one assigned
Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsafrane @k8s-ci-robot