Skip to content

kubelet: remove allocationManager's reference to containerManager #133428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kubelet: remove allocationManager's reference to containerManager #133428

wants to merge 1 commit into from
+35 −27

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Aug 7, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

IIUC we don't expect the NodeConfig or NodeAllocatableAbsolute to change once initialized. Since these values are all that the allocation manager needs from the container manager, pass just those in instead of a reference to the entire container manager.

Which issue(s) this PR is related to:

This comment: #131801 (comment)
Might help with this issue: #132298

Special notes for your reviewer:

Can wait for 1.35

Does this PR introduce a user-facing change?

NONE

/sig node
/assign @tallclair

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.34 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.34.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 7 16:22:30 UTC 2025.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 7, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Aug 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from mrunalp and tzneal August 7, 2025 19:23
@natasha41575 natasha41575 changed the title remove allocationManager's reference to containerManager kubelet: remove allocationManager's reference to containerManager Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: natasha41575, seemadurrani
Once this PR has been reviewed and has the lgtm label, please ask for approval from tallclair. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@natasha41575
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 7, 2025 •
edited
Loading

@natasha41575: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows-master 9a6db5a link false /test pull-kubernetes-unit-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node: code and documentation PRs Aug 8, 2025
@bart0sh
Copy link
Contributor

bart0sh commented Aug 8, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemadurrani seemadurrani seemadurrani approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@tzneal tzneal Awaiting requested review from tzneal

Assignees

@tallclair tallclair

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Status: Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@natasha41575 @k8s-ci-robot @bart0sh @seemadurrani @tallclair