Skip to content

Remove DeprecatedVersion for apiserver_storage_objects, adjust help text #133431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

Remove DeprecatedVersion for apiserver_storage_objects, adjust help text #133431

merged 1 commit into from
Aug 8, 2025
+13 −14

Conversation

richabanker
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes the DeprecatedVersion=1.34.0 from apiserver_storage_objects
One of the follow ups from here

Which issue(s) this PR is related to:

Issue: #133429

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updates help text for `apiserver_storage_objects` metric to show that its deprecated and mention apiserver_resource_objects as its replacement

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.34 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.34.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 7 16:22:30 UTC 2025.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 7, 2025
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2025
@richabanker richabanker force-pushed the etcd-metrics-delete branch from 27e5010 to 91d3148 Compare August 7, 2025 21:09
@k8s-ci-robot k8s-ci-robot added area/stable-metrics Issues or PRs involving stable metrics sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Aug 7, 2025
@richabanker
Copy link
Contributor Author

/sig instrumentation
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 7, 2025
@richabanker
Copy link
Contributor Author

@BenTheElder @liggitt @michaelasp @serathius @dgrisonnet

@richabanker
Copy link
Contributor Author

/milestone v1.34

@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Aug 7, 2025
michaelasp
michaelasp approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@michaelasp michaelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix!

@richabanker richabanker force-pushed the etcd-metrics-delete branch from 91d3148 to 6263949 Compare August 7, 2025 21:53
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2025
@k8s-triage-robot
Copy link

This PR may require stable metrics review.

Stable metrics are guaranteed to not change. Please review the documentation for the requirements and lifecycle of stable metrics and ensure that your metrics meet these guidelines.

BenTheElder
BenTheElder reviewed Aug 7, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5446689c4b8f10647a918cc6ab01210a6baf8a65

@liggitt
Copy link
Member

liggitt commented Aug 7, 2025

verify failure looks legitimate, need to regen metrics descriptors

other two look like DRA flakes :-/

{Failed  === RUN   TestDRA/all/DeviceBindingConditions
    dra_test.go:1670: add binding condition to second claim:
            <*errors.StatusError | 0xc001f5d220>: 
            Operation cannot be fulfilled on resourceclaims.resource.k8s.io "my-pod-my-resource-b": the object has been modified; please apply your changes to the latest version and try again

That test must expect / tolerate / retry conflict errors if it is concurrently modifying an object. cc @johnbelamaric @KobayashiD27 - please open an issue tracking this flake and make that test more robust.

The e2e failure is #133384 - cc @johnbelamaric @yliaog

@richabanker richabanker force-pushed the etcd-metrics-delete branch from 6263949 to cbd6fb8 Compare August 8, 2025 00:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2025
@richabanker
Copy link
Contributor Author

/retest

@richabanker
Copy link
Contributor Author

/assign @serathius

@BenTheElder
Copy link
Member

Looks like we also hit the stream translator unit flakes again

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/133431/pull-kubernetes-unit/1953613653546635264

the DRA integration test flake was https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/133431/pull-kubernetes-integration/1953575194152931328

the e2e flake should hopefully be fixed shortly

@BenTheElder
Copy link
Member

#130018 Most recently, but that package has been plagued with flakes.

@KobayashiD27 KobayashiD27 mentioned this pull request Aug 8, 2025
Open
@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aabd62142f8a1274e0953c02a94321ae9444eda8

@serathius
Copy link
Contributor

/approve

@richabanker richabanker mentioned this pull request Aug 8, 2025
Open
@richabanker
Copy link
Contributor Author

cc @kubernetes/release-team-leads @Vyom-Yadav

This PR needs to be included in the 1.34 release.
We are missing approval from @logicalhan but I have also raised a PR to expand the list of approvers for these kind of changes.

Meanwhile @liggitt might be able to help get the necessarily approval.

logicalhan
logicalhan approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, michaelasp, richabanker, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit f003bd2 into kubernetes:master Aug 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@michaelasp michaelasp michaelasp approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@logicalhan logicalhan

@BenTheElder BenTheElder

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/stable-metrics Issues or PRs involving stable metrics cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
8 participants
@richabanker @k8s-ci-robot @k8s-triage-robot @liggitt @BenTheElder @serathius @logicalhan @michaelasp