Skip to content

test: Standardize labels for ResourceHealthStatus e2e tests #133432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: Standardize labels for ResourceHealthStatus e2e tests #133432

wants to merge 1 commit into from
+1 −2

Conversation

Jpsassine
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This change updates the Ginkgo label for the Device Plugin e2e tests for the ResourceHealthStatus feature.

By switching from feature.ResourceHealthStatus to framework.WithFeatureGate(features.ResourceHealthStatus), these tests will now have the [FeatureGate:ResourceHealthStatus] label. This makes them consistent with the new DRA e2e tests for the same feature implemented here #130606

This standardization is a prerequisite for a follow-up change in test-infra that will allow a single presubmit job to correctly select and run all e2e tests for this feature, ensuring complete test coverage

Which issue(s) this PR is related to:

Special notes for your reviewer:

This is the first of a two part fix to unify test coverage for the ResourceHealthStatus feature.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@Jpsassine
test: Standardize labels for ResourceHealthStatus e2e tests
76bbaa9 
This change updates the Ginkgo label for the Device Plugin e2e tests for the ResourceHealthStatus feature.

By switching from `feature.ResourceHealthStatus` to `framework.WithFeatureGate(features.ResourceHealthStatus)`, these tests will now have the `[FeatureGate:ResourceHealthStatus]` label, making them consistent with the new DRA e2e tests for the same feature.

This standardization allows a single presubmit job in `test-infra` to correctly select and run all e2e tests for this feature, ensuring complete test coverage.
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.34 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.34.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 7 16:22:30 UTC 2025.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 7, 2025
@Jpsassine
Copy link
Contributor Author

/assign @SergeyKanzhelev

@Jpsassine Jpsassine marked this pull request as ready for review August 7, 2025 21:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 7, 2025
@Jpsassine
Copy link
Contributor Author

/test pull-kubernetes-unit

@Jpsassine
Copy link
Contributor Author

Note: The presubmit job test-args filter was merged before this change, kubernetes/test-infra#35283.

The device plugin e2e tests for the ResourceHealthStatus feature will not be picked up until this is merged.

@Jpsassine
Copy link
Contributor Author

/test pull-kubernetes-node-e2e-resource-health-status

SergeyKanzhelev
SergeyKanzhelev approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c82599f412c391039daefcd7c5c4bf4e91da05e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jpsassine, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2025
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node: code and documentation PRs Aug 12, 2025
@bart0sh
Copy link
Contributor

bart0sh commented Aug 12, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@ffromani ffromani Awaiting requested review from ffromani

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Status: Triage
SIG Node: code and documentation PRs
Status: Needs Approver
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jpsassine @k8s-ci-robot @bart0sh @SergeyKanzhelev