-
Notifications
You must be signed in to change notification settings - Fork 41.1k
e2e: node: cpumanager: replace the test suite #133463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Is not ideal to heve utilities source file or packages, because these tend to be unfocused and attract unstructured code, easily leading to a kitchesink approach. So, let's start cleaning up by splitting the utilities we have to deal with kubelet config in its own source file, lacking bandwidth now for deeper refactorings. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
A lot ofe2e_node tests need to re-learn machine HW properties to check the correctness of the behavior. Over time, we start using these utilities among different test groups (e.g. memory manager tests use cpu manager tests utilites). So let's de-entangle this state by moving the shared utilities in a separate util file. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
Push more utilities from cpu manager tests to util.go. This time there is not a clear (or big enough) them for this set of shared code blocks. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
Since is now all about criprozy, rename utils_linux.go to better express the purpose. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
We're nearing the planned replacement of old cpumanager tests with new ones, so move the remaining utilities which we will keep using with the new codebase. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
The topology manager tests wants to run a subset of cpumanager tests while checking numa alignment. We should eventually rewrite these bits to reuse the new and cleaner rewritten cpu manager tests. For the time being, we move the shared bits in the topology manager tests, so we are now enabled to remove the remaining obsolete cpu manager tests with the rewritten ones. Trivial code movement, no intended behavioral changes. Signed-off-by: Francesco Romani <fromani@redhat.com>
superseded by code in cpumanager_test.go, which will be moved in cpu_manager_test.go at the end of this series. Split to make the review easier. Signed-off-by: Francesco Romani <fromani@redhat.com>
superseded by code in cpumanager_test.go, which will be moved in cpu_manager_test.go at the end of this series. Split to make the review easier. Signed-off-by: Francesco Romani <fromani@redhat.com>
superseded by code in cpumanager_test.go, which will be moved in cpu_manager_test.go at the end of this series. Split to make the review easier. Signed-off-by: Francesco Romani <fromani@redhat.com>
superseded by code in cpumanager_test.go, which will be moved in cpu_manager_test.go at the end of this series. Split to make the review easier. Signed-off-by: Francesco Romani <fromani@redhat.com>
superseded by code in cpumanager_test.go, which will be moved in cpu_manager_test.go at the end of this series. Split to make the review easier. Signed-off-by: Francesco Romani <fromani@redhat.com>
keep only the test stub, as all the code was already removed by PR in the series because superseded by code in cpumanager_test.go, which will be moved in cpu_manager_test.go at the end of this series. Split to make the review easier. Signed-off-by: Francesco Romani <fromani@redhat.com>
This final change in the series completes the transition to the new test suite Fixes: kubernetes#129884 Signed-off-by: Francesco Romani <fromani@redhat.com>
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 11 10:25:10 UTC 2025. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ffromani: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
LGTM label has been added. Git tree hash: dfc32aaacc43c98740417a1e3ab5ce6614fac240
|
/hold Sorry, I failed to point out clearly this PR depends on #133462, fixing now |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Replace the old cpumanager tests with the new suites rewritten and tested through the full 1.34 cycle.
The new testsuite is a superset of the old suite, so we gain coverage.
Which issue(s) this PR is related to:
#129884
Special notes for your reviewer:
This PR depends on and requires #133462
Previous work
Does this PR introduce a user-facing change?