Please note that we're already in Test Freeze for the release-1.34 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.34.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 12 04:23:31 UTC 2025.

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Hi @mayooot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

/label api-review

the PodFailurePolicyOnPodConditionsPattern type documents type and status fields as required, since they are not marked as +optional and are not omitempty

we can verify that those fields are marked as required in openapi:

    "io.k8s.api.batch.v1.PodFailurePolicyOnPodConditionsPattern": {
      "description": "PodFailurePolicyOnPodConditionsPattern describes a pattern for matching an actual pod condition type.",
      "properties": {
        "status": {
          "description": "Specifies the required Pod condition status. To match a pod condition it is required that the specified status equals the pod condition status. Defaults to True.",
          "type": "string"
        },
        "type": {
          "description": "Specifies the required Pod condition type. To match a pod condition it is required that specified type equals the pod condition type.",
          "type": "string"
        }
      },
      "required": [
        "type",
        "status"
      ],
      "type": "object"
    },

however, if I submit a manifest to the server omitting that field, the API server does accept it and defaults the status field to True

func SetDefaults_PodFailurePolicyOnPodConditionsPattern(obj *batchv1.PodFailurePolicyOnPodConditionsPattern) {
	if obj.Status == "" {
		obj.Status = corev1.ConditionTrue
	}
}

That means the status field is not actually required.

I think the correct change here would be to mark the field as // +optional to fix the advertised openapi.

@liggitt Got it, I'll update it soon.

/ok-to-test
/lgtm
/approve

LGTM label has been added.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mayooot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/retest-required

Status is not explicitly set to "True", which may lead to errors in Python Kubernetes client generated by upstream.

if this is leading to errors, does that mean the client is doing blocking client-side validation by default? that's not really recommended... is there an issue in the python library tracking that?

Status is not explicitly set to "True", which may lead to errors in Python Kubernetes client generated by upstream.

if this is leading to errors, does that mean the client is doing blocking client-side validation by default? that's not really recommended... is there an issue in the python library tracking that?

I think this can be resolved once this PR has been mered, because Status is not required. Therefore, the genereated codes will change as folows:
Before:

def __init__(self, status=None, type=None, local_vars_configuration=None):

After:

def __init__(self, type=None, local_vars_configuration=None):

And the python status function will be changed to look like this:

    @status.setter
    def status(self, status):
        """Sets the status of this V1PodFailurePolicyOnPodConditionsPattern.

        Specifies the required Pod condition status. To match a pod condition it is required that the specified status equals the pod condition status. Defaults to True.  # noqa: E501

        :param status: The status of this V1PodFailurePolicyOnPodConditionsPattern.  # noqa: E501
        :type: str
        """
-        if self.local_vars_configuration.client_side_validation and status is None:  # noqa: E501
-            raise ValueError("Invalid value for `status`, must not be `None`")  # noqa: E501

        self._status = status

WDYT?