Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS under the hood doc with ELB SSL annotations #25574

Merged
merged 1 commit into from
May 20, 2016
Merged

Update AWS under the hood doc with ELB SSL annotations #25574

merged 1 commit into from
May 20, 2016

Conversation

therc
Copy link
Member

@therc therc commented May 13, 2016

Document #23495. No e2e tests or release notes needed (the other PR is already in the release docs).

@therc
Copy link
Member Author

therc commented May 13, 2016

cc @justinsb

@k8s-github-robot k8s-github-robot added kind/design Categorizes issue or PR as related to design. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels May 13, 2016
therc added a commit to therc/kubernetes.github.io that referenced this pull request May 13, 2016
@therc
Update service doc with AWS ELB SSL annotations
0700c5c 
Mostly the same as kubernetes/kubernetes#25574
@therc therc mentioned this pull request May 13, 2016
Merged
@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. e2e-not-required and removed release-note-label-needed labels May 16, 2016
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2016
@therc
Copy link
Member Author

therc commented May 16, 2016

I reran updated-generated-docs, rebased and squashed the change. Sorry I hadn't noticed the failure earlier, I think I only saw one of the emails about successful tests.

@therc
Copy link
Member Author

therc commented May 16, 2016

@k8s-bot test this issue #23822

@k8s-bot
Copy link

k8s-bot commented May 16, 2016

GCE e2e build/test passed for commit 54c55fd.

@therc
Copy link
Member Author

therc commented May 20, 2016

@brendandburns could you reapply the LGTM?

@justinsb justinsb added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2016
@justinsb justinsb added this to the v1.3 milestone May 20, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9625926 into kubernetes:master May 20, 2016
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
Merge pull request kubernetes#25574 from Clarifai/elb
71f47d8 
Automatic merge from submit-queue

Update AWS under the hood doc with ELB SSL annotations

Document kubernetes#23495. No e2e tests or release notes needed (the other PR is already in the release docs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@therc @k8s-bot @k8s-github-robot @justinsb @googlebot @brendandburns