Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use multi-arch busybox for e2e #54034

Merged
merged 1 commit into from
Oct 19, 2017
Merged

use multi-arch busybox for e2e #54034

merged 1 commit into from
Oct 19, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Oct 17, 2017

What this PR does / why we need it:
Since multi-arch is supported already for Official images on Dockerhub, we can use busybox directly instead of having our own GetBusyBoxImage for multi-arch.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
xref #53958

Special notes for your reviewer:
/assign @mkumatag @ixdy

Release note:

Use multi-arch busybox image for e2e

@k8s-ci-robot
Copy link
Contributor

@dixudx: GitHub didn't allow me to assign the following users: mkumatag.

Note that only kubernetes members can be assigned.

In response to this:

What this PR does / why we need it:
Since multi-arch is supported already for Official images on Dockerhub, we can use busybox directly instead of having our own GetBusyBoxImage for multi-arch.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
xref #53958

Special notes for your reviewer:
/assign @mkumatag @ixdy

Release note:

Use multi-arch busybox image for e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 17, 2017
@dixudx
Copy link
Member Author

dixudx commented Oct 17, 2017

@mkumatag Per our discussion, I think we can update busybox in our e2e as well.

@ixdy
Copy link
Member

ixdy commented Oct 18, 2017 •
edited
Loading

/ok-to-test
/approve

Seems fine to me. @mkumatag @luxas do you agree?

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 18, 2017
mkumatag
mkumatag approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dixudx
Copy link
Member Author

dixudx commented Oct 18, 2017

ping @quinton-hoole @shashidharatd for approval. Thanks.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2017
@shashidharatd
Copy link

/lgtm
Please fix the rebase issue. will apply the lgtm again. Thanks !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2017
@dixudx dixudx force-pushed the e2e_multiarch_busybox branch from a400548 to f7f3577 Compare October 19, 2017 02:36
@dixudx
Copy link
Member Author

dixudx commented Oct 19, 2017

@shashidharatd Rebased. PTAL.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 19, 2017
@shashidharatd
Copy link

/test pull-kubernetes-federation-e2e-gce
/test pull-kubernetes-e2e-gce-gpu

@shashidharatd
Copy link

/lgtm
federation pre-submit is failing due to some infra issue and not related to the PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, ixdy, shashidharatd

Associated issue: 53958

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dixudx
Copy link
Member Author

dixudx commented Oct 19, 2017

/retest

@k8s-ci-robot
Copy link
Contributor

@dixudx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce f7f3577 link /test pull-kubernetes-federation-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52753, 54034, 53982, 54209). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 809987d into kubernetes:master Oct 19, 2017
@dixudx dixudx deleted the e2e_multiarch_busybox branch October 19, 2017 09:47
@luxas
Copy link
Member

luxas commented Oct 19, 2017

Thanks @dixudx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

Assignees

@ixdy ixdy

@shashidharatd shashidharatd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dixudx @k8s-ci-robot @ixdy @shashidharatd @k8s-github-robot @luxas @mkumatag