@serathius: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

/assign @logicalhan

I don't know too much about bazel rule.
I'm not quite sure if we can modify files under vendor/.

And I think we should wait for all migration done.

This seems like a fairly reasonable approach, although it does mean that if a user runs rm -Rf vendor/ and hack/update-vendor.sh, their vendor directory will be incorrect/not up to date with what it was before.

Alternatively, could you define:

package_group(
    name = "allow_list",
    includes = [":internal"],
    packages = [
        "//cluster/images/etcd-version-monitor",
        "//pkg/controller/endpointslice",
        "//pkg/controller/volume/attachdetach/metrics",
        "//pkg/controller/volume/persistentvolume/metrics",
        "//pkg/kubelet/metrics/collectors",
        "//pkg/kubelet/pleg",
        "//pkg/kubelet/pluginmanager/metrics",
        "//pkg/kubelet/server",
        "//pkg/kubelet/server/stats",
        "//pkg/kubelet/volumemanager/metrics",
        "//pkg/master",
        "//pkg/scheduler/framework/v1alpha1",
        "//pkg/volume/util/operationexecutor",
        "//staging/src/k8s.io/apiserver/pkg/admission/metrics",
        "//staging/src/k8s.io/component-base/metrics/...",
        "//test/e2e",
        "//test/e2e/storage",
        "//test/e2e_node",
        "//vendor/...",
    ],
)

in a package not in vendor/, and then use buildozer to update the visibility setting in all packages under vendor/github.com/prometheus to be the required value? You would likely want to add the additional call to buildozer here: https://github.com/kubernetes/kubernetes/blob/master/hack/update-bazel.sh#L82

This would then mean that git clone k/k.git && rm -Rf vendor/ && ./hack/update-vendor.sh would result in a clean tree.

@munnerz This is a great suggestion! Thanks!

From a Bazel and general repo management, this looks good to me 😄 with regards to whether or not sig-instrumentation want to do this/whether this should be approved is not up to me 😄

So adding my lgtm and leaving to the appropriate OWNERS to decide on approval...

/lgtm

/retest

/milestone v1.17

/assign @BenTheElder @logicalhan

/approve
for hack/

/retest

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, logicalhan, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here