Skip to content

Remove prometheus references from pkg/controller/endpointslice #85289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2020
Merged

Remove prometheus references from pkg/controller/endpointslice #85289

merged 1 commit into from
Mar 5, 2020

Conversation

serathius
Copy link
Contributor

/kind feature
Ref kubernetes/enhancements#1238

/cc @RainbowMango

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 14, 2019
@fedebongio
Copy link
Contributor

/cc @logicalhan

RainbowMango
RainbowMango reviewed Nov 15, 2019
View reviewed changes
@serathius
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor

/assign @robscott

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2020
logicalhan
logicalhan reviewed Jan 24, 2020
View reviewed changes
@serathius serathius force-pushed the remove-prometheus-controller-endpointslice branch from 4d82d01 to c41d106 Compare January 24, 2020 08:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2020
@serathius serathius closed this Jan 24, 2020
@serathius serathius force-pushed the remove-prometheus-controller-endpointslice branch from c41d106 to a38096a Compare January 24, 2020 08:59
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2020
@serathius serathius reopened this Jan 24, 2020
@serathius serathius force-pushed the remove-prometheus-controller-endpointslice branch from 49021e8 to 85bd8fa Compare January 24, 2020 12:44
@serathius
Copy link
Contributor Author

/retest

1 similar comment
@robscott
Copy link
Member

/retest

robscott
robscott reviewed Jan 24, 2020
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! Mostly LGTM, but might be nice to add a helper function to help with error handling.

@serathius serathius force-pushed the remove-prometheus-controller-endpointslice branch from 85bd8fa to 62ab485 Compare January 31, 2020 14:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2020
@robscott
Copy link
Member

/retest

@robscott
Copy link
Member

Thanks! Assigning Minhan to approve this.

/lgtm
/assign @freehan

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2020
@serathius
Copy link
Contributor Author

/retest

@serathius serathius mentioned this pull request Feb 6, 2020
Merged
freehan
freehan approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 19, 2020
@serathius serathius force-pushed the remove-prometheus-controller-endpointslice branch from 62ab485 to 4ea52da Compare February 29, 2020 14:10
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 29, 2020
@serathius
Copy link
Contributor Author

serathius commented Mar 4, 2020 •
edited
Loading

@freehan Can you /lgtm ?

@robscott
Copy link
Member

robscott commented Mar 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 0836b58 into kubernetes:master Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 5, 2020
@serathius serathius mentioned this pull request Mar 19, 2020
Open
7 tasks
@serathius serathius deleted the remove-prometheus-controller-endpointslice branch July 11, 2020 12:06
@ggriffiths ggriffiths mentioned this pull request Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@logicalhan logicalhan logicalhan left review comments

@RainbowMango RainbowMango RainbowMango left review comments

@freehan freehan freehan approved these changes

Assignees

@robscott robscott

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
9 participants
@serathius @fedebongio @danwinship @robscott @k8s-ci-robot @fejta-bot @logicalhan @freehan @RainbowMango