Collect some of scheduling metrics and scheduling throughput (vol. 2) #87923
Conversation
a0afa2b to
45a74be
Compare
|
Thanks for handling this. |
45a74be to
5dee21d
Compare
|
/retest |
1 similar comment
|
/retest |
5dee21d to
8d02e94
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
9b7653a to
ac0633f
Compare
|
/retest |
|
|
||
| // GetHistogramFromBuckets creates a histogram from a list of buckets. | ||
| // Given individual samples are unknown, SampleSum is not computed. | ||
| func GetHistogramFromBuckets(buckets []bucket) Histogram { |
There was a problem hiding this comment.
it is strange that we have a function that creates a histogram from buckets, and then we convert back to buckets when computing quantiles. I suggest we remove this function, the other PR should create a dto.Histogram directly from the samples.
There was a problem hiding this comment.
Yeah, the code was not designed to accept anything but dto.Histogram.
In addition to getting overall performance measurements from golang benchmark, collect metrics that provides information about insides of the scheduler itself. This is a first step towards improving what we collect about the scheduler. Metrics in question: - scheduler_scheduling_algorithm_predicate_evaluation_seconds - scheduler_scheduling_algorithm_priority_evaluation_seconds - scheduler_binding_duration_seconds - scheduler_e2e_scheduling_duration_seconds Scheduling throughput is computed on the fly inside perfScheduling.
ac0633f to
7b55340
Compare
|
/test pull-kubernetes-e2e-gce |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, ingvagabund, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/retest |
|
@ingvagabund: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
In addition to getting overall performance measurements from golang benchmark,
collect metrics that provides information about inside of the scheduling itself.
Metrics in question:
Scheduling throughput is computed on the fly inside benchmarkScheduling.
Also, due to restrictions introduced by Metrics Stability Migration KEP, one should not depend on
prometheus internals directly.
Re-picking #85861 which was reverted by #87897
Fixes: #87923
What type of PR is this?
/kind feature
What this PR does / why we need it:
Resolving #85861 (comment)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: