Skip to content

Remove prometheus references from etcd version monitor #89413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2020
Merged

Remove prometheus references from etcd version monitor #89413

merged 1 commit into from
Mar 27, 2020

Conversation

zhouya0
Copy link
Contributor

@zhouya0 zhouya0 commented Mar 24, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:
Part of #89267

Which issue(s) this PR fixes:

Fixes ##89267

Special notes for your reviewer:
/cc @RainbowMango
/cc @serathius
Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 24, 2020
@k8s-ci-robot k8s-ci-robot requested a review from serathius March 24, 2020 06:45
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 24, 2020
@RainbowMango
Copy link
Member

Basically sounds good to me.
We still have a little bit more complex part that is github.com/prometheus/client_model/go, we can handle it by next round.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@RainbowMango
Copy link
Member

/kind cleanup
/priority backlog
/remove-sig api-machinery
/remove-sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 24, 2020
@serathius
Copy link
Contributor

/assign @BenTheElder

@zhouya0
Copy link
Contributor Author

zhouya0 commented Mar 27, 2020

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims March 27, 2020 07:41
@dims
Copy link
Member

dims commented Mar 27, 2020

/approve

@dims
Copy link
Member

dims commented Mar 27, 2020

thanks @zhouya0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, RainbowMango, zhouya0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@serathius serathius mentioned this pull request Mar 27, 2020
Open
7 tasks
@k8s-ci-robot k8s-ci-robot merged commit 3842a92 into kubernetes:master Mar 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 27, 2020
@BenTheElder
Copy link
Member

/approve
seems reasonable, though I'm not sure I grokked the full implications, I'll have to read that KEP thoroughly at some point.

@BenTheElder
Copy link
Member

heh, this is what I get for circling back to a "TODO" tab, guess @dims beat me by a day :-)

@dims
Copy link
Member

dims commented Mar 28, 2020

LOL @BenTheElder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

@serathius serathius Awaiting requested review from serathius

@dims dims Awaiting requested review from dims

Assignees

@BenTheElder BenTheElder

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
6 participants
@zhouya0 @RainbowMango @serathius @dims @k8s-ci-robot @BenTheElder