Skip to content

Scheduler: remove direct import to /pkg/util/parsers #90008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2020
Merged

Scheduler: remove direct import to /pkg/util/parsers #90008

merged 1 commit into from
May 16, 2020

Conversation

gavinfish
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Scheduler: remove direct import to /pkg/util/parsers

Which issue(s) this PR fixes:

Ref #89930

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from damemi and Huang-Wei April 9, 2020 15:35
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 9, 2020
damemi
damemi approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but some things I'm thinking that we might want to consider:

This const is only used in 1 other spot (pkg/kubelet/images), so could it be cleaned up there too?

Going even further, does latest really need to be a constant for the default image tag? Ie, do we foresee having to change that? It's actually shorter to type latest than defaultImageTag in the first place so I'm not sure what's gained by having a constant for something that's kind of assumed. But I'm not strict about that, just thinking out loud.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2020
@gavinfish
Copy link
Contributor Author

gavinfish commented Apr 12, 2020 •
edited
Loading

@damemi

This const is only used in 1 other spot (pkg/kubelet/images), so could it be cleaned up there too?

Letting kubelet depend on k/util looks good to me. I think it is unnecessary to duplicate it in kubelet too.

Going even further, does latest really need to be a constant for the default image tag? Ie, do we foresee having to change that? It's actually shorter to type latest than defaultImageTag in the first place so I'm not sure what's gained by having a constant for something that's kind of assumed. But I'm not strict about that, just thinking out loud.

+1. This constant is introduced five years ago in #17278. It is never changed and I cannot foresee any cases it may change. I can remove the constant if it looks better.

@damemi damemi mentioned this pull request Apr 23, 2020
Open
@damemi
Copy link
Member

damemi commented Apr 23, 2020

@gavinfish would you like to add another commit removing the const entirely? We'll need kubelet owners to approve that and then we can get their opinion on it

@gavinfish gavinfish force-pushed the scheduler-utilparsers branch from 38ad8c4 to 70c6a0a Compare April 26, 2020 15:39
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2020
@gavinfish gavinfish force-pushed the scheduler-utilparsers branch from 70c6a0a to 0b715ea Compare April 26, 2020 15:42
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2020
@gavinfish
Copy link
Contributor Author

@damemi I just remove the DefaultImageTag const to make it more consice.

@gavinfish
Copy link
Contributor Author

/retest

damemi
damemi approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
will need approval from a pkg owner as well

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2020
@damemi
Copy link
Member

damemi commented May 6, 2020

/assign @lavalamp
could you ptal at this? it's removing the DefaultImageTag which has been latest unchanged for 5 years

@derekwaynecarr
Copy link
Member

kubelet change lgtm.

/approve
/lgtm

@damemi
Copy link
Member

damemi commented May 13, 2020

Thanks @derekwaynecarr

@lavalamp polite ping, this needs a pkg/ approver

@lavalamp
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, gavinfish, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@damemi
Copy link
Member

damemi commented May 14, 2020

pull-kubernetes-files-remake Expected — Waiting for status to be reported

this looks new, anything we need to do to poke it?

@gavinfish
Copy link
Contributor Author

/test pull-kubernetes-files-remake

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

6 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 9769e0f into kubernetes:master May 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 16, 2020
@gavinfish gavinfish deleted the scheduler-utilparsers branch November 19, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@lavalamp lavalamp

@damemi damemi

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
6 participants
@gavinfish @damemi @derekwaynecarr @lavalamp @k8s-ci-robot @fejta-bot