Scheduler:remove direct dependency for pkg/api/testing #90041
Conversation
pkg/scheduler/factory.go
Outdated
| @@ -528,3 +528,14 @@ func GetPodDisruptionBudgetLister(informerFactory informers.SharedInformerFactor | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // v1DeepEqualSafePodSpec returns a PodSpec which is ready to be used with apiequality.Semantic.DeepEqual | |||
There was a problem hiding this comment.
see https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cli-runtime/pkg/resource/helper_test.go#L59
maybe we can use this v1DeepEqualSafePodSpec after moving it to helper.go not stay here.
/cc @damemi
What do you think?
There was a problem hiding this comment.
Yeah that's a good question, because on one hand it's already an exported function there, but on the other I only see cli-runtime being imported by kubectl-related code. So I don't think it would really fit here.
However, does this even need to be a function? I see it's only being called once in factory_test.go and it returns a constant PodSpec. So could we just put this podspec in that spot instead?
There was a problem hiding this comment.
So could we just put this podspec in that spot instead?
Agree
There was a problem hiding this comment.
updated , pls review it again.
|
/test pull-kubernetes-e2e-kind-ipv6 |
|
/test pull-kubernetes-e2e-kind-ipv6 |
1 similar comment
|
/test pull-kubernetes-e2e-kind-ipv6 |
|
/cc @liggitt |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, tanjunchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind cleanup |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
ref:#89930
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: