Skip to content

Scheduler:remove direct dependency for k8s.io/kubernetes/pkg/controller/volume/scheduling/metrics #90046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Scheduler:remove direct dependency for k8s.io/kubernetes/pkg/controller/volume/scheduling/metrics #90046

wants to merge 1 commit into from

Conversation

tanjunchen
Copy link
Contributor

@tanjunchen tanjunchen commented Apr 10, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref:#89930

Special notes for your reviewer:

pkg/scheduler and pkg/controller are using it.

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 10, 2020
@tanjunchen tanjunchen changed the title Scheduler:remove direct dependency for k8s.io/kubernetes/pkg/controller/volume/scheduling/metrics [WIP] Scheduler:remove direct dependency for k8s.io/kubernetes/pkg/controller/volume/scheduling/metrics Apr 10, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2020
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 10, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 10, 2020 •
edited
Loading

@tanjunchen: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-storage-snapshot c703ffbaac209c91ef6292e11bfb1a8954fb661f link /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gce-storage-slow c703ffbaac209c91ef6292e11bfb1a8954fb661f link /test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-gce-csi-serial c703ffbaac209c91ef6292e11bfb1a8954fb661f link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tanjunchen
To complete the pull request process, please assign ravisantoshgudimetla
You can assign the PR to them by writing /assign @ravisantoshgudimetla in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tanjunchen tanjunchen changed the title [WIP] Scheduler:remove direct dependency for k8s.io/kubernetes/pkg/controller/volume/scheduling/metrics Scheduler:remove direct dependency for k8s.io/kubernetes/pkg/controller/volume/scheduling/metrics Apr 14, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2020
@tanjunchen
Copy link
Contributor Author

/cc @damemi

@k8s-ci-robot k8s-ci-robot requested a review from damemi April 14, 2020 02:52
@damemi
Copy link
Member

damemi commented Apr 14, 2020

@ahg-g this looks like another volumebinding dependency, maybe we should collect the PRs around that into a single spot? I'm not sure about duplicating these metrics

@tanjunchen
Copy link
Contributor Author

@ahg-g this looks like another volumebinding dependency, maybe we should collect the PRs around that into a single spot? I'm not sure about duplicating these metrics

ok

@damemi damemi mentioned this pull request Apr 23, 2020
Open
@damemi
Copy link
Member

damemi commented Apr 23, 2020

Cross-ref to the other PR I was talking about: #90007

damemi
damemi suggested changes May 6, 2020
View reviewed changes
pkg/scheduler/metrics/metrics.go
// Register all metrics.
func Register() {
// Register the metrics.
registerMetrics.Do(func() {
RegisterMetrics(metricsList...)
volumeschedulingmetrics.RegisterVolumeSchedulingMetrics()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is only called by the scheduler, so it can be removed.

The metrics definitions are also only used in pkg/controller/volume/scheduling/scheduler_binder.go and pkg/controller/volume/scheduling/metrics/metrics.go, so they can be updated to refer to the new definitions in pkg/scheduler/metrics/metrics.go (and so their definitions also removed).

With this, I believe the entire pkg/controller/volume/scheduling/metrics package can be removed

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 4, 2020
@k8s-ci-robot
Copy link
Contributor

@tanjunchen: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2020
@tanjunchen tanjunchen closed this Aug 6, 2020
@tanjunchen tanjunchen deleted the sche-remove-dependency-002 branch August 6, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi requested changes

@lichuqiang lichuqiang Awaiting requested review from lichuqiang

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanjunchen @k8s-ci-robot @damemi @fejta-bot