Move to tar-fs. #2402
Move to tar-fs. #2402
Conversation
There was a problem hiding this comment.
Left a couple comments.
I'm good with this approach, but I do think it might be worthwhile to also pursue a license exception for BlueOak. I realize JavaScript isn't the primary language of most CNCF projects, but I would be surprised if this didn't happen again in some CNCF controlled repo. My understanding is that Isaac (the author of all of the packages in #2392) intends to move all of his modules to this license over time, and a lot of those modules are heavily depended on.
| import { WritableStreamBuffer } from 'stream-buffers'; | ||
| import * as tar from 'tar'; |
There was a problem hiding this comment.
There are some linter errors in this file.
package.json
Outdated
| @@ -72,6 +72,7 @@ | |||
| "socks-proxy-agent": "^8.0.4", | |||
| "stream-buffers": "^3.0.2", | |||
| "tar": "^7.0.0", | |||
There was a problem hiding this comment.
tar should be removed from this file and package-lock.json
| import { WritableStreamBuffer } from 'stream-buffers'; | ||
| import * as tar from 'tar'; | ||
| import tmp from 'tmp-promise'; |
There was a problem hiding this comment.
Sorry for the back and forth - I think this is the only use of this dependency in the project. If it's removed here, it can be removed from package.json and package-lock.json too.
There was a problem hiding this comment.
Done (and removed ws also since it is not a direct dependency)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, cjihrig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #2392
tar-fs only depends on MIT, ISC and Apache 2 licensed dependencies.