fix: respect NODE_TLS_REJECT_UNAUTHORIZED environment variable #2602
Conversation
|
/lgtm Thanks for updating the test. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0x5457, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tests are failing with some error related to generating the certificate. |
@0x5457 seems like you would need to pass in an option to define the key size: https://github.com/jfromaniello/selfsigned?tab=readme-ov-file#options 2048 should be sufficient. Having a fixture certificate seems better to me as well but as this is only a dev dependency I would be fine with it. |
|
New changes are detected. LGTM label has been removed. |
1782cf2 to
830dd41
Compare
|
Replaced Generated using OpenSSL: mkdir -p testdata/certs
openssl genrsa -out testdata/certs/test-key.pem 2048
openssl req -new -x509 -key testdata/certs/test-key.pem \
-out testdata/certs/test-cert.pem -days 999999 -subj "/CN=localhost" |
with static certs
830dd41 to
42cde8e
Compare
fix: #2601
After testing, I found that the fetch behavior is as follows:
Also should I can create test certificates in the test-data directory to avoid introducing the selfsigned library