Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.19.2
Choose a base ref
...
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.19.3
Choose a head ref
  • 7 commits
  • 11 files changed
  • 5 contributors

Commits on Nov 30, 2024

  1. warning: Use leader elector with client timeout

    This change makes the leader elector use a client that internally has
    a smaller timeout than the renew deadline, which avoids a situation
    where a single request timing out makes us lose the leader lease.
    alvaroaleman authored and k8s-infra-cherrypick-robot committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    0170742 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. 🐛 Fix RenewDeadline typo in leader election

    Signed-off-by: Vince Prignano <vince@prigna.com>
    vincepri committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    4bc3811 View commit details
    Browse the repository at this point in the history
  2. 🌱 Make using leader elector with client timeout non-breaking

    This change is a follow-up to the one that introduces the usage of the
    leader-elector with client timeout. That change was breaking because it
    introduces a new option and always assumed it was set. This change makes
    us only use that option if its actually set.
    alvaroaleman authored and vincepri committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2a0ce59 View commit details
    Browse the repository at this point in the history
  3. [release-0.19] 🐛 Refactor certificate watcher to use polling, instead…

    … of fsnotify (#3023)
    
    * Reestablish watch for the certificate paths
    
    * Remove fsnotify and use cached read watcher
    
    * Simplify return
    
    * 🐛Fix certwatcher test to be backwards compatible
    
    ---------
    
    Co-authored-by: Maxim Muzafarov <m.muzafarov@gmail.com>
    k8s-infra-cherrypick-robot and m-messiah authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e727239 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #3031 from k8s-infra-cherrypick-robot/cherry-pick-…

    …3028-to-release-0.19
    
    [release-0.19] 🐛 Use leader elector with client timeout
    k8s-ci-robot authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    0823530 View commit details
    Browse the repository at this point in the history
  5. add watch deprecated to certwatcher

    Signed-off-by: Vince Prignano <vince@prigna.com>
    vincepri committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2085acc View commit details
    Browse the repository at this point in the history
  6. Merge pull request #3037 from kubernetes-sigs/backport019-watch

    🌱 add deprecated Watch() to certwatcher
    k8s-ci-robot authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3e66810 View commit details
    Browse the repository at this point in the history
Loading