feat: adds image-load and kind-load Make targets #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks like this needs a rebase, but will re-approve when done, thanks! /lgtm |
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
|
@kfswain I made a few minor tweaks- changed target names and included |
|
/lgtm |
coolkp
pushed a commit
to coolkp/llm-instance-gateway
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
coolkp
pushed a commit
to coolkp/llm-instance-gateway
that referenced
this pull request
Feb 13, 2025
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* Integrate dynamic-lora-sidecar into main guide and add makefile, cloudbuild to build and publish lora-syncer image Signed-off-by: Kunjan <kunjanp@google.com> * Add makefile and cloudbuild file to build and push lora-syncer Signed-off-by: Kunjan <kunjanp@google.com> * Add makefile and cloudbuild file to build and push lora-syncer Signed-off-by: Kunjan <kunjanp@google.com> * Update site-src/guides/dynamic-lora.md Co-authored-by: Abdullah Gharaibeh <40361897+ahg-g@users.noreply.github.com> * Update site-src/guides/dynamic-lora.md Co-authored-by: Abdullah Gharaibeh <40361897+ahg-g@users.noreply.github.com> * Add makefile and cloudbuild file to build and push lora-syncer Signed-off-by: Kunjan <kunjanp@google.com> * Adds image-load and kind-load Make targets (#288) Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * Add makefile and cloudbuild file to build and push lora-syncer Signed-off-by: Kunjan <kunjanp@google.com> * Add build targets for lora syncer Signed-off-by: Kunjan <kunjanp@google.com> * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review --------- Signed-off-by: Kunjan <kunjanp@google.com> Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> Co-authored-by: Abdullah Gharaibeh <40361897+ahg-g@users.noreply.github.com> Co-authored-by: Daneyon Hansen <daneyon.hansen@solo.io>
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
* Integrate dynamic-lora-sidecar into main guide and add makefile, cloudbuild to build and publish lora-syncer image Signed-off-by: Kunjan <kunjanp@google.com> * Add makefile and cloudbuild file to build and push lora-syncer Signed-off-by: Kunjan <kunjanp@google.com> * Add makefile and cloudbuild file to build and push lora-syncer Signed-off-by: Kunjan <kunjanp@google.com> * Update site-src/guides/dynamic-lora.md Co-authored-by: Abdullah Gharaibeh <40361897+ahg-g@users.noreply.github.com> * Update site-src/guides/dynamic-lora.md Co-authored-by: Abdullah Gharaibeh <40361897+ahg-g@users.noreply.github.com> * Add makefile and cloudbuild file to build and push lora-syncer Signed-off-by: Kunjan <kunjanp@google.com> * Adds image-load and kind-load Make targets (kubernetes-sigs#288) Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * Add makefile and cloudbuild file to build and push lora-syncer Signed-off-by: Kunjan <kunjanp@google.com> * Add build targets for lora syncer Signed-off-by: Kunjan <kunjanp@google.com> * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review --------- Signed-off-by: Kunjan <kunjanp@google.com> Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> Co-authored-by: Abdullah Gharaibeh <40361897+ahg-g@users.noreply.github.com> Co-authored-by: Daneyon Hansen <daneyon.hansen@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
image-loadandkind-loadMake targets.Fixes #287