Skip to content

added license header to all .go files #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

added license header to all .go files #370

merged 1 commit into from
Feb 19, 2025

Conversation

nirrozenbaum
Copy link
Contributor

fix #281

@nirrozenbaum
added license header to all .go files
48d4fca 
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nirrozenbaum. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 19, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 48d4fca
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67b5f7b25be58d0008179296
😎 Deploy Preview https://deploy-preview-370--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nirrozenbaum nirrozenbaum mentioned this pull request Feb 19, 2025
Closed
ArangoGutierrez
ArangoGutierrez approved these changes Feb 19, 2025
View reviewed changes
Copy link

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this
I'll leave the lgtm to a second eye

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@kfswain
Copy link
Collaborator

kfswain commented Feb 19, 2025

/lgtm

Thanks Nir!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 435a40d into kubernetes-sigs:main Feb 19, 2025
8 checks passed
rramkumar1 pushed a commit to rramkumar1/gateway-api-inference-extension that referenced this pull request Mar 3, 2025
@nirrozenbaum @rramkumar1
added license header to all .go files (kubernetes-sigs#370)
d55d2b1 
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@nirrozenbaum nirrozenbaum mentioned this pull request Mar 5, 2025
Closed
11 tasks
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
@nirrozenbaum @kfswain
added license header to all .go files (kubernetes-sigs#370)
f2a1fa9 
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

Assignees

@kfswain kfswain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license headers to all files
4 participants
@nirrozenbaum @k8s-ci-robot @kfswain @ArangoGutierrez