updated logging in inferencepool reconciler #399
Conversation
|
Hi @nirrozenbaum. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
| logger := log.FromContext(ctx) | ||
| loggerDefault := logger.V(logutil.DEFAULT) | ||
| loggerDefault.Info("Reconciling InferencePool", "name", req.NamespacedName) | ||
| logger := log.FromContext(ctx).WithValues("Request.NamespacedName", req.NamespacedName).V(logutil.DEFAULT) |
There was a problem hiding this comment.
| logger := log.FromContext(ctx).WithValues("Request.NamespacedName", req.NamespacedName).V(logutil.DEFAULT) | |
| logger := log.FromContext(ctx).WithValues("inferencePool", req.NamespacedName).V(logutil.DEFAULT) | |
| ctx = ctrl.LoggerInto(ctx, logger) |
putting it back into the context preservers the value downstream.
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
b97161d to
fc9f838
Compare
|
@nirrozenbaum there is an extra file in this PR, can you pls remove it? |
after adding predicate to the controller registration, the reconcile function no longer contains the filtering logic. therefore, it's not relecant to test the reconcile function with pool2. in runtime, this event will be filtered out much earlier Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
ed26f54 to
d86fc39
Compare
yes, sorry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* updated logging + predicate in inferencepool reconciler Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * removed irrelevant unit test. after adding predicate to the controller registration, the reconcile function no longer contains the filtering logic. therefore, it's not relecant to test the reconcile function with pool2. in runtime, this event will be filtered out much earlier Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
* updated logging + predicate in inferencepool reconciler Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * removed irrelevant unit test. after adding predicate to the controller registration, the reconcile function no longer contains the filtering logic. therefore, it's not relecant to test the reconcile function with pool2. in runtime, this event will be filtered out much earlier Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
use the
.WithValuesfunction instead of having to specify the NamespacedName in every log line.