Syncing getting started guide all to main #410
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Fixes #407 |
| @@ -23,7 +23,8 @@ This quickstart guide is intended for engineers familiar with k8s and model serv | |||
| ### Install the Inference Extension CRDs | |||
|
|
|||
| ```bash | |||
| kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/v0.1.0/manifests.yaml | |||
| kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/crd/bases/inference.networking.x-k8s.io_inferencepools.yaml | |||
| kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/crd/bases/inference.networking.x-k8s.io_inferencemodels.yaml | |||
There was a problem hiding this comment.
can we just do one command, like:
kubectl apply -k https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/crd
There was a problem hiding this comment.
I tried running that locally and kustomize didnt love it (I think because we have to include /raw in the pathing).
Happy to tune this in a following PR if we'd like, just want to get the readme unblocked ASAP
|
/lgtm |
Disconnecting the current readme from the v0.1.0 release of the manifest. Will have a follow up PR to create a separate version locked getting started guide