Skip to content

predicate follow up PR to remove the check from Reconcile func #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2025
Merged

predicate follow up PR to remove the check from Reconcile func #418

merged 2 commits into from
Feb 27, 2025

Conversation

nirrozenbaum
Copy link
Contributor

this is a follow up pr to #397 after I reverted changes that were done in Reconcile func to reduce the conflicts with #393

@nirrozenbaum
predicate follow up PR to remove the check from Reconcile func
598eac9 
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nirrozenbaum. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nirrozenbaum
Copy link
Contributor Author

/assign @ahg-g

@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit cca0531
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67c0a31fd2d2300008e7f438
😎 Deploy Preview https://deploy-preview-418--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2025
@kfswain
Copy link
Collaborator

kfswain commented Feb 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2025
@nirrozenbaum
removed irrelevant test after introducing predicate
cca0531 
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 27, 2025 •
edited
Loading

We frankly reduced our test coverage with this change ...

@nirrozenbaum
Copy link
Contributor Author

We frankly reduced our test coverage with this change ...

we removed unit tests, but if we want we can add some scenarios in e2e tests (like the one that was removed here).
the test that was removed is not relevant anymore cause events are filtered in an earlier stage.
I'm totally in favor of adding more tests, but from the other hand if we're run irrelevant tests it doesn't give us too much.

@ahg-g
Copy link
Contributor

ahg-g commented Feb 27, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit d2c6e7a into kubernetes-sigs:main Feb 27, 2025
8 checks passed
@nirrozenbaum nirrozenbaum deleted the predicate branch February 27, 2025 22:43
@nirrozenbaum nirrozenbaum mentioned this pull request Mar 5, 2025
Closed
11 tasks
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
@nirrozenbaum @kfswain
predicate follow up PR to remove the check from Reconcile func (kuber…
1e76d43 
…netes-sigs#418)

* predicate follow up PR to remove the check from Reconcile func

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

* removed irrelevant test after introducing predicate

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>

---------

Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirrozenbaum @k8s-ci-robot @kfswain @ahg-g