-
Notifications
You must be signed in to change notification settings - Fork 73
Mis cleanup #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mis cleanup #428
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the PR, the changes it proposes are a matter of preference, I am happy to approve it if you feel strongly about it, although I don't quite agree with most it. Other things that I feel we are not spending enough time on is testing and debuggability, here are a few examples: Testing
Debugability Usability I added a lot of tests in a previous PRs, but we are still lacking sufficient coverage, I am planning to continue to do that, and I would appreciate the help here :) |
Yes, they are mostly nit cleanups just one fix in pkg/epp/controller/inferencemodel_reconciler.go |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.