API Proposal #5
Merged
API Proposal #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahg-g
reviewed
Sep 5, 2024
coolkp
reviewed
Sep 5, 2024
raywainman
reviewed
Sep 6, 2024
yuzisun
reviewed
Sep 7, 2024
Joffref
reviewed
Sep 8, 2024
11 tasks
|
/assign would like to help review, ping myself for a mark |
arkodg
reviewed
Oct 2, 2024
arkodg
reviewed
Oct 2, 2024
robscott
reviewed
Oct 3, 2024
|
/label tide/merge-method-squash |
ahg-g
reviewed
Oct 3, 2024
ahg-g
reviewed
Oct 4, 2024
| // services should be consumed by only the backendpool they are part | ||
| // of. Should this behavior be breached, routing behavior is not | ||
| // guaranteed. | ||
| ServiceRef []corev1.ObjectReference |
There was a problem hiding this comment.
It will be set on the httpRoute, this is only to identify the backends.
ahg-g
reviewed
Oct 4, 2024
ahg-g
reviewed
Oct 4, 2024
ahg-g
reviewed
Oct 4, 2024
ahg-g
reviewed
Oct 4, 2024
|
/lgtm Congratulations! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Congrats! |
Merged
mayabar
pushed a commit
to mayabar/gateway-api-inference-extension
that referenced
this pull request
Apr 17, 2025
…odules/golang.org/x/net-0.38.0 Bump golang.org/x/net from 0.37.0 to 0.38.0
kfswain
added a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
* Big ol proposal commit * 1st round of addressing comments * Partial glossary implementation * API updates * glossary additions * adding axioms and faq * Addressing review comments * more proposal updates * clarifying plural modelgroup * editing comment to max col 80 len * More explicit documentation on plural usecases * Adding examples and word clarification * Adding persona summary to ModelGroup obj * Changing Constants to adhere to style guide * Grammatical fixes * Changing BackendPool acronym * CUJ description clarification * Adding back BackendPool with description * Updating names to LLM Service and LLMServerPool * Typos, rewording, and small fixes * another review pass * link fixes * fixing wording, removing duplication * shortining targetmodel name field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the initial proposal for what the LLM Instance Gateway API surface might look like. Much of this is rough-in, and expected to change.