-
Notifications
You must be signed in to change notification settings - Fork 72
switch to using formal vllm-cpu image #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cc @kfswain |
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@@ -14,7 +14,7 @@ spec: | |||
spec: | |||
containers: | |||
- name: lora | |||
image: "seedjeffwan/vllm-cpu-env:bb392af4-20250203" | |||
image: "public.ecr.aws/q9t5s3a7/vllm-cpu-release-repo:v0.7.2" # formal images can be found in https://gallery.ecr.aws/q9t5s3a7/vllm-cpu-release-repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who owns the release of this image? vllm? what does q9t5s3a7
refer to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. vllm owns this image.
see this issue I’ve opened:
vllm-project/vllm#14756
/lgtm 2 questions that I think should be nonblocking:
Holding for @ahg-g to finish review and for questions, thanks Nir!! |
|
This is still not working for me, and I get the same error (see below). Is this expected to work on specific CPU architectures? Traceback (most recent call last): |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ok, deployed on an intel machine and it worked, previously I was testing on N2D (an AMD architecture machine). We need to clarify that in the guide if indeed the image is built to work with specific architecture. |
Is there an image which supports AMD architecture? |
* switch to formal vllm-cpu image Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * documentation of formal vllm-cpu image Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * minor updates to cpu deployment Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
No description provided.