Skip to content

remove controller-runtime dependency from API #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

remove controller-runtime dependency from API #565

merged 1 commit into from
Mar 24, 2025

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Mar 24, 2025

Fixes #564

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans March 24, 2025 20:15
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 24, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 24, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit f945b57
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67e1bd7497ee500008329d02
😎 Deploy Preview https://deploy-preview-565--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ahg-g
ahg-g reviewed Mar 24, 2025
View reviewed changes
api/v1alpha2/zz_generated.register.go
// +build !ignore_autogenerated

/*
Copyright 2024 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some template needs updating somewhere to make this 2025 :)

@ahg-g
Copy link
Contributor

ahg-g commented Mar 24, 2025

/lgtm

/hold

for the possibility to update the template

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@kfswain
Copy link
Collaborator Author

kfswain commented Mar 24, 2025

for the possibility to update the template

Ahh good point! I ran it locally and it exploded the diff, so to keep things clean ill fastfollow with an update of the boilerplate + generate.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7bbb836 into kubernetes-sigs:main Mar 24, 2025
8 checks passed
@kfswain kfswain deleted the cr-removal branch March 27, 2025 19:45
kfswain added a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
@kfswain
remove controller-runtime dependency from API (kubernetes-sigs#565)
3a5f7f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@danehans danehans Awaiting requested review from danehans

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Controller-Runtime Dependencies from API Types
3 participants
@kfswain @k8s-ci-robot @ahg-g