Fixes Kgateway in Quickstart Guide #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
|
@robscott @LiorLieberman can you confirm that specifying |
|
/hold |
for istio it wont matter - will be best to figure out a way to communicate its doesnt impact anything |
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
ahg-g
reviewed
Mar 31, 2025
| @@ -114,7 +133,7 @@ This quickstart guide is intended for engineers familiar with k8s and model serv | |||
|
|
|||
| - Gateway API [CRDs](https://gateway-api.sigs.k8s.io/guides/#installing-gateway-api) installed. | |||
|
|
|||
| 1. Install Istio | |||
| 2. Install Istio | |||
There was a problem hiding this comment.
using 1. is better since it should automatically increment I believe
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
|
/lgtm |
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
* Fixes Kgateway in Quickstart Guide Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * Moves HTTPRoutes to implementations Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * Bumps kgtw to rc.2 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> --------- Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
* Fixes Kgateway in Quickstart Guide Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * Moves HTTPRoutes to implementations Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * Bumps kgtw to rc.2 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> --------- Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
* Fixes Kgateway in Quickstart Guide Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * Moves HTTPRoutes to implementations Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> * Bumps kgtw to rc.2 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io> --------- Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$VERSIONwhich defines the Inference Extension version and not the Kgateway version.portto be defined for an InferencePool backendRef.Prerequisitessection.v2.0.0-rc.1release tag sincev2.0.0has not been released yet.