Skip to content

Fix pytest warnings for test module #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

feffe
Copy link
Contributor

@feffe feffe commented Jul 19, 2019

When TestCase and TestSuite are imported into the test module, they cause pytest warnings. Pytest expects classes named Test* to be test classes and will try to collect tests in them. Test classes should not implement init. I have just renamed the classes here after import in order to avoid warnings.

@sysradium
Copy link
Collaborator

Probably this needs a rebase since build is failing?

@feffe feffe force-pushed the fix-test-warnings branch from 9ae2712 to a98d1e0 Compare July 19, 2019 18:24
@feffe
Copy link
Contributor Author

feffe commented Jul 19, 2019

I have rebased. Now it's all green.

@sysradium
Copy link
Collaborator

Perfect, thanks!

@sysradium sysradium merged commit 5ea26cd into kyrus:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants