Skip to content

Show new AtCoder URL to the submission page #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 9, 2019
Merged

Show new AtCoder URL to the submission page #128

merged 3 commits into from
Mar 9, 2019

Conversation

kotamanegi
Copy link
Contributor

issue#118 の通り、submission結果として表示されるURLを新しいものに変更しました。
(内部処理に使用するURLは変えていません)

@codecov-io
Copy link

codecov-io commented Mar 8, 2019 •
edited
Loading

Codecov Report

Merging #128 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   88.65%   88.62%   -0.03%     
==========================================
  Files          49       49              
  Lines        2212     2215       +3     
==========================================
+ Hits         1961     1963       +2     
- Misses        251      252       +1
Impacted Files Coverage Δ
atcodertools/client/models/contest.py 90.9% <33.33%> (-4.1%) ⬇️
atcodertools/tools/utils.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ac5b4...aab8a78. Read the comment docs.

kyuridenamida
kyuridenamida reviewed Mar 8, 2019
View reviewed changes
@kotamanegi
Copy link
Contributor Author

変更点は全て納得、という感じです。
とりあえずCIを確認して修正点がありそうならば修正します。

@kyuridenamida
Copy link
Owner

良さそうなのでマージします！どうもです

@kyuridenamida
Copy link
Owner

明日こちらでも実際提出できるかどうか確認しますね

@kyuridenamida
Copy link
Owner

その後マージします

kyuridenamida
kyuridenamida requested changes Mar 9, 2019
View reviewed changes
@kyuridenamida kyuridenamida changed the title Fix issue#118 Show URL to the submissions page on new AtCoder Mar 9, 2019
@kyuridenamida kyuridenamida merged commit c07fcdd into kyuridenamida:master Mar 9, 2019
@kyuridenamida kyuridenamida changed the title Show URL to the submissions page on new AtCoder Show new AtCoder URL to the submissions page Mar 9, 2019
@kyuridenamida kyuridenamida changed the title Show new AtCoder URL to the submissions page Show new AtCoder URL to the submission page Mar 9, 2019
@kotamanegi kotamanegi deleted the issue/118 branch March 9, 2019 07:34
@kyuridenamida kyuridenamida mentioned this pull request Mar 9, 2019
Closed
@kyuridenamida kyuridenamida modified the milestones: 1.0.3, 1.1.4 Apr 10, 2019
@kyuridenamida kyuridenamida mentioned this pull request Apr 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyuridenamida kyuridenamida kyuridenamida approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kotamanegi @codecov-io @kyuridenamida