Skip to content

Conversation

chaemon
Copy link
Contributor

@chaemon chaemon commented Dec 15, 2019

整数の判定において、先頭が0だったり、文字数が20以上だったりした場合にFalseにして文字列にするようにしました。

@codecov-io
Copy link

codecov-io commented Dec 15, 2019

Codecov Report

Merging #172 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #172      +/-   ##
=========================================
+ Coverage   87.77%   87.8%   +0.03%     
=========================================
  Files          56      56              
  Lines        3117    3125       +8     
=========================================
+ Hits         2736    2744       +8     
  Misses        381     381
Impacted Files Coverage Δ
atcodertools/fmtprediction/predict_types.py 99.09% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6ef3d...f4b8890. Read the comment docs.

@kyuridenamida kyuridenamida merged commit 3c1e33e into kyuridenamida:master Dec 15, 2019
@kyuridenamida kyuridenamida changed the title 整数判定において、先頭が0だったり、文字数が20以上だったらFalseにするように Recognize an integer token as a string token when it has a leading zero or more than 19 digits Dec 15, 2019
@kyuridenamida kyuridenamida changed the title Recognize an integer token as a string token when it has a leading zero or more than 19 digits Recognize an integer token as a string token when it has a leading zero or more than 19 digits in format prediction Dec 15, 2019
@kyuridenamida kyuridenamida changed the title Recognize an integer token as a string token when it has a leading zero or more than 19 digits in format prediction Recognize an integer token as a string token when it has a leading zero or too many digits in format prediction Dec 15, 2019
@kyuridenamida kyuridenamida added this to the 1.1.7 milestone Jan 1, 2020
kyuridenamida pushed a commit that referenced this pull request May 16, 2020
* 整数判定において、先頭が0だったり、文字数が20以上だったらFalseにするように

* answer.txtを変更

* test_mod_caseをstringに
kyuridenamida added a commit that referenced this pull request May 16, 2020
* 整数判定において、先頭が0だったり、文字数が20以上だったらFalseにするように (#172)

* 整数判定において、先頭が0だったり、文字数が20以上だったらFalseにするように

* answer.txtを変更

* test_mod_caseをstringに

* Makes gen command retry with exponential backoff (#174)

Previously, gen command retries with fixed delay of 1.5 seconds indefinitely. It could hurt the service especially when they are experiencing overloaded traffic. This patch changes the retry strategy with exponential backoff starting from 1.5 seconds to 60 seconds at maximum. The gen commands aborts by EnvironmentInitializationError exception after 10 attempts.

* #186 Support \dots in input formats (#187)

* C++言語アップデートへの対応 (#191)

* Fix cpp language configs

* Update atcodertools/common/language.py

Co-authored-by: DNEK <dnek.app@gmail.com>

Co-authored-by: Kazuma Mikami <tyotyo3@gmail.com>
Co-authored-by: DNEK <dnek.app@gmail.com>

* Pythonの言語アップデートに対応 (#192)

* Fix crash in new judgement using Python

* Fix bugs of Python2 submissions in old judgement

Co-authored-by: Matts966 <Matts966@users.noreply.github.com>

* 新しい言語のバージョンに対応 (#196)

* 新しい言語のバージョンに対応

* gen, submitを新しいのに対応

* Fix regexps

Co-authored-by: Kazuma Mikami <tyotyo3@gmail.com>

* Fix style

* Update mock pages

* Fix submissions

* Fix flake8

Co-authored-by: chaemon <chaemon@gmail.com>
Co-authored-by: Yuki Hamada <yuuki3655@gmail.com>
Co-authored-by: Takaaki Hirano <thescript1210@gmail.com>
Co-authored-by: DNEK <dnek.app@gmail.com>
Co-authored-by: Matts966 <28551465+Matts966@users.noreply.github.com>
Co-authored-by: Matts966 <Matts966@users.noreply.github.com>
chaemon added a commit to chaemon/atcoder-tools that referenced this pull request May 11, 2021
* 整数判定において、先頭が0だったり、文字数が20以上だったらFalseにするように (kyuridenamida#172)

* 整数判定において、先頭が0だったり、文字数が20以上だったらFalseにするように

* answer.txtを変更

* test_mod_caseをstringに

* Makes gen command retry with exponential backoff (kyuridenamida#174)

Previously, gen command retries with fixed delay of 1.5 seconds indefinitely. It could hurt the service especially when they are experiencing overloaded traffic. This patch changes the retry strategy with exponential backoff starting from 1.5 seconds to 60 seconds at maximum. The gen commands aborts by EnvironmentInitializationError exception after 10 attempts.

* kyuridenamida#186 Support \dots in input formats (kyuridenamida#187)

* C++言語アップデートへの対応 (kyuridenamida#191)

* Fix cpp language configs

* Update atcodertools/common/language.py

Co-authored-by: DNEK <dnek.app@gmail.com>

Co-authored-by: Kazuma Mikami <tyotyo3@gmail.com>
Co-authored-by: DNEK <dnek.app@gmail.com>

* Pythonの言語アップデートに対応 (kyuridenamida#192)

* Fix crash in new judgement using Python

* Fix bugs of Python2 submissions in old judgement

Co-authored-by: Matts966 <Matts966@users.noreply.github.com>

* 新しい言語のバージョンに対応 (kyuridenamida#196)

* 新しい言語のバージョンに対応

* gen, submitを新しいのに対応

* Fix regexps

Co-authored-by: Kazuma Mikami <tyotyo3@gmail.com>

* Fix style

* Update mock pages

* Fix submissions

* Fix flake8

Co-authored-by: chaemon <chaemon@gmail.com>
Co-authored-by: Yuki Hamada <yuuki3655@gmail.com>
Co-authored-by: Takaaki Hirano <thescript1210@gmail.com>
Co-authored-by: DNEK <dnek.app@gmail.com>
Co-authored-by: Matts966 <28551465+Matts966@users.noreply.github.com>
Co-authored-by: Matts966 <Matts966@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants