Skip to content

Simplify Judge class #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 4, 2020
Merged

Simplify Judge class #180

merged 7 commits into from
Jan 4, 2020

Conversation

kyuridenamida
Copy link
Owner

No description provided.

@kyuridenamida kyuridenamida changed the title Make logic naive for readability (Can be worse) Simplify Judge class Jan 3, 2020
@codecov-io
Copy link

codecov-io commented Jan 3, 2020 •
edited
Loading

Codecov Report

Merging #180 into master will increase coverage by 1.88%.
The diff coverage is 80.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   85.86%   87.74%   +1.88%     
==========================================
  Files          57       57              
  Lines        3162     3158       -4     
==========================================
+ Hits         2715     2771      +56     
+ Misses        447      387      -60
Impacted Files Coverage Δ
atcodertools/tools/models/metadata.py 94.87% <100%> (ø) ⬆️
atcodertools/common/judgetype.py 87.65% <100%> (-0.77%) ⬇️
atcodertools/config/config.py 98.73% <100%> (+0.03%) ⬆️
atcodertools/tools/setter.py 67.69% <50%> (-2.63%) ⬇️
atcodertools/tools/compiler.py 68.18% <66.66%> (+14.84%) ⬆️
atcodertools/tools/tester.py 83.4% <84.61%> (+1.79%) ⬆️
atcodertools/executils/run_program.py 69.65% <85%> (+35.34%) ⬆️
atcodertools/tools/templates/__init__.py 83.33% <0%> (-16.67%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ccab88...79ff3e9. Read the comment docs.

@kyuridenamida kyuridenamida force-pushed the refactor_judge_methods branch from fdf667b to f6ce5bf Compare January 3, 2020 20:51
@kyuridenamida kyuridenamida merged commit 6dd4966 into master Jan 4, 2020
@kyuridenamida kyuridenamida added this to the 1.1.8 milestone May 16, 2020
@kyuridenamida kyuridenamida deleted the refactor_judge_methods branch April 17, 2021 10:05
@kyuridenamida kyuridenamida added the dev-env-improvement Not for production, but for dev environment label Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev-env-improvement Not for production, but for dev environment
Projects
None yet
Milestone
1.1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@kyuridenamida @codecov-io