Refactor user config path setting #256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
すみません、pushするブランチを間違えました。今対応出来ないので後ほど対応します。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Refactoring because the following source code does not use USER_CONFIG_PATH in atcodertools/config/config.py.
atcodertools/tools/compiler.py
atcodertools/tools/envgen.py
_(Japanese)
下記のソースコードでは、atcodertools/config/config.pyのUSER_CONFIG_PATHを使用していないためリファクタリング。
atcodertools/tools/compiler.py
atcodertools/tools/envgen.py
What did you implement?
Replaced the USER_CONFIG_PATH defined for each source code with the USER_CONFIG_PATH in atcodertools/config/config.py.
_(Japanese)
ソースコード毎に定義してあるUSER_CONFIG_PATHを、atcodertools/config/config.py のUSER_CONFIG_PATHに置き換えた。
What behavior do you expect?
If the
atcoder-tools genandatcoder-tools compiletests pass, you're good to go._(Japanese)
atcoder-tools genとatcoder-tools compileのテストが通ればOK