Skip to content

stop having the runner script just as script but instead have a scrip… #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2018
Merged

stop having the runner script just as script but instead have a scrip… #46

merged 1 commit into from
Dec 29, 2018

Conversation

kyuridenamida
Copy link
Owner

…t as console_script

@codecov-io
Copy link

Codecov Report

Merging #46 into master will decrease coverage by 0.9%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   73.15%   72.25%   -0.91%     
==========================================
  Files          24       25       +1     
  Lines        1356     1373      +17     
==========================================
  Hits          992      992              
- Misses        364      381      +17
Impacted Files Coverage Δ
atcodertools/tools/run_script.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93eb63b...d05f124. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Dec 29, 2018 •
edited
Loading

Codecov Report

Merging #46 into master will decrease coverage by 0.9%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   73.15%   72.25%   -0.91%     
==========================================
  Files          24       25       +1     
  Lines        1356     1373      +17     
==========================================
  Hits          992      992              
- Misses        364      381      +17
Impacted Files Coverage Δ
atcodertools/tools/run_script.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93eb63b...d05f124. Read the comment docs.

@kyuridenamida kyuridenamida merged commit 94a9f85 into master Dec 29, 2018
@kyuridenamida
Copy link
Owner Author

This might resolve the issue that you can't install atcoder-tools script correctly from pip on some Linux environment.

kyuridenamida added a commit that referenced this pull request Dec 29, 2018
@kyuridenamida
Revert "stop having the runner script just as script but instead have…
f4c7a4a 
… a script as console_script (#46)"

This reverts commit 94a9f85.
@kyuridenamida kyuridenamida mentioned this pull request Dec 29, 2018
Merged
kyuridenamida added a commit that referenced this pull request Dec 29, 2018
@kyuridenamida
Revert "stop having the runner script just as script but instead have…
1ae4cb4 
… a script as console_script (#46)" (#47)

This reverts commit 94a9f85.
@kyuridenamida kyuridenamida deleted the better_setup branch April 17, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyuridenamida @codecov-io