Skip to content

introduce postprocess config with exec_on_each_problem_dir / exec_on_contest_dir… #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 6, 2019
Merged

introduce postprocess config with exec_on_each_problem_dir / exec_on_contest_dir… #59

merged 10 commits into from
Jan 6, 2019

Conversation

kyuridenamida
Copy link
Owner

@kyuridenamida kyuridenamida commented Jan 2, 2019 •
edited
Loading

  • postprocess.exec_on_each_problem_dir 毎回問題用のディレクトリが生成された後に実行するコマンド。cwdは問題用のディレクトリ(workspace/arc001/Aとか)
  • postprocess.exec_on_contest_dir コンテストのディレクトリを生成したあとに一度だけ実行するコマンド。cwdはコンテスト用のディレクトリ(workspace/arc001/とか)

例: .atcodertools.tomlに以下を書くと、問題用ディレクトリ内で毎回clang-formatを実行して、最後にCMakeLists.txtをコンテスト用ディレクトリに生成する。

[codestyle]
indent_type = 'space' # 'tab' or 'space'
indent_width = 4

[postprocess]
exec_on_each_problem_dir='clang-format -i ./*.cpp'
exec_on_contest_dir='touch CMakeLists.txt'

@kyuridenamida kyuridenamida mentioned this pull request Jan 2, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jan 2, 2019 •
edited
Loading

Codecov Report

Merging #59 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   91.36%   91.49%   +0.12%     
==========================================
  Files          34       36       +2     
  Lines        1668     1704      +36     
==========================================
+ Hits         1524     1559      +35     
- Misses        144      145       +1
Impacted Files Coverage Δ
atcodertools/config/config.py 100% <100%> (ø)
atcodertools/tools/envgen.py 82.73% <100%> (+0.91%) ⬆️
atcodertools/tools/postprocess_config.py 100% <100%> (ø)
atcodertools/codegen/code_style_config.py 93.75% <100%> (ø)
atcodertools/codegen/cpp_code_generator.py 94.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a710a3...ce6efde. Read the comment docs.

@asi1024
Copy link
Collaborator

asi1024 commented Jan 3, 2019

[codegen], [envgen] という名前はわかりづらいです．
例えば [codestyle], [postprocess] とかはどうでしょう

@kyuridenamida
Copy link
Owner Author

kyuridenamida commented Jan 3, 2019 •
edited
Loading

賛成です。envgen->postprocessにするとしたら、exec_after_problem_created / exec_after_contest_created の名前はこのままで大丈夫ですか?好みありますか?

@kyuridenamida kyuridenamida self-assigned this Jan 3, 2019
@kyuridenamida kyuridenamida requested a review from asi1024 January 3, 2019 17:33
@asi1024
Copy link
Collaborator

asi1024 commented Jan 4, 2019

#54 を Merge した後にもう一度テストを回し直しましょう

@kyuridenamida
Copy link
Owner Author

kyuridenamida commented Jan 4, 2019 •
edited
Loading

exec_foreach_problemとexec_for_contestにした。cwdの違いの説明も足した

@kyuridenamida
Copy link
Owner Author

kyuridenamida commented Jan 4, 2019 •
edited
Loading

exec_on_each_problem_dirとexec_on_contest_dirのほうがコマンドとしての機能はよく説明できてる気がするが冗長かなあ

@asi1024
Copy link
Collaborator

asi1024 commented Jan 4, 2019

ええんちゃう？

@kyuridenamida
Copy link
Owner Author

良さそうだったらマージしてくれると嬉しいです。1月05日なため(?) 1.0.5をリリースしたいです

@kyuridenamida kyuridenamida added this to the 1.0.5 milestone Jan 5, 2019
@asi1024
Copy link
Collaborator

asi1024 commented Jan 5, 2019

流石，大阪出身はこんなに面白いジョーク言えるんやね

@asi1024
Copy link
Collaborator

asi1024 commented Jan 5, 2019

ユーザから見える部分についてはOKです．テスト通してmergeの流れでいきましょう

@asi1024 asi1024 mentioned this pull request Jan 5, 2019
Closed
@kyuridenamida kyuridenamida merged commit 0f9c83a into master Jan 6, 2019
@kyuridenamida
Copy link
Owner Author

しまったPRのタイトルいじるの忘れてた。まあいいや...次から気をつけます

@kyuridenamida kyuridenamida changed the title introduce envgen config with exec_after_problem_created / exec_after_… introduce postprocess config with exec_on_each_problem_dir / exec_on_contest_dir… Jan 6, 2019
@kyuridenamida kyuridenamida deleted the issue/56 branch April 17, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asi1024 asi1024 Awaiting requested review from asi1024

Assignees

@kyuridenamida kyuridenamida

Labels
enhancement
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@kyuridenamida @codecov-io @asi1024