Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

Angular Way - Doesn't support '$' char in controller variable #916

Closed
koalalam opened this issue Nov 30, 2016 · 1 comment
Closed

Angular Way - Doesn't support '$' char in controller variable #916

koalalam opened this issue Nov 30, 2016 · 1 comment
Labels
duplicate

Comments

@koalalam
Copy link

What versions you are using?

  • jquery version:
  • datatables version:
  • angular-datatables version: 0.5.5

What's the problem?

Angular Way doesn't work when '$' char is used in controller variable while '$ctrl' is the default value of controller in Angular Component (https://docs.angularjs.org/guide/component#comparison-between-directive-definition-and-component-definition).

The regex doesn't match here: https://github.com/l-lin/angular-datatables/blob/v0.5.5/dist/angular-datatables.js#L892

One workaround is to override the default controller name e.g. controllerAs: ctrl

Can you share your code?
@l-lin
Copy link
Owner

l-lin commented Nov 30, 2016

See #893. It will be fixed in the next version.

@l-lin l-lin closed this as completed Nov 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@l-lin @koalalam