This repository was archived by the owner on Feb 2, 2025. It is now read-only.
Fix ng pipe and TemplateRef for tables with invisible columns #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue #1721. |
shanmukhateja
approved these changes
Apr 5, 2023
l-lin
approved these changes
Apr 6, 2023
|
Can you add a unit test for this so we don't run into it in the future? |
|
@khicks any update on this? |
|
Closing in favor of #1725 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying Angular features like pipe and TemplateRef on a table with invisible columns, there is a discrepancy between the column definition and the resulting HTML. The library makes reference to the resulting HTML when modifying the table and assumes invisible columns are present in the DOM.
This proposed fix ensures that only visible columns are considered when deciding which column(s) to modify when applying pipe transforms or templates.