Skip to content
This repository was archived by the owner on Feb 2, 2025. It is now read-only.

Added $ to the ng-repeat directive comment regex #893

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

Jared314
Copy link
Contributor

@Jared314 Jared314 commented Nov 1, 2016

The regular expression searching for the <!-- ngRepeat: item in items --> comment directive was not matching correctly when the binding contained a $, like item in $ctrl.items.

This change adds the $ to the matched symbols.

@l-lin l-lin merged commit 2a33ee6 into l-lin:dev Nov 3, 2016
l-lin added a commit that referenced this pull request Nov 3, 2016
@l-lin l-lin added this to the v0.5.6 milestone Nov 3, 2016
@l-lin
Copy link
Owner

l-lin commented Nov 3, 2016

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants