Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OF-compatible queue handling #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable OF-compatible queue handling #79

wants to merge 2 commits into from

Conversation

eugene-che
Copy link

  • Remove the restriction on queue ids
    • now it is possible to create queues with the same id at different ports;
  • Fix qos scheduler initialization:
    • add a more rigorous checks for shaping parameters;
    • rollback to previos scheduler config on errors;
    • map queues to DPDK scheduler to enable PQ;
  • Enable queue scheduling for each transmitted packet;
  • Add support for queue_config and queue_stats openflow requests;
  • Change DPDK build options to enable qos scheduler statistics.

@eugene-che
Enable OF-compatible queue handling
a228835 
- Remove the restriction on queue ids
    - now it is possible to create queues with the same id at different ports;
- Fix qos scheduler initialization:
    - add a more rigorous checks for shaping parameters;
    - rollback to previos scheduler config on errors;
    - map queues to DPDK scheduler to enable PQ;
- Enable queue scheduling for each transmitted packet;
- Add support for queue_config and queue_stats openflow requests;
- Change DPDK build options to enable qos scheduler statistics.
ynkjm
ynkjm reviewed May 9, 2016
View reviewed changes
mk/make_dpdk.sh
@@ -81,6 +81,7 @@ edit_dpdk_config CONFIG_RTE_LIBRTE_PMD_PCAP=n $NEWCONFIG
edit_dpdk_config CONFIG_RTE_APP_TEST=n $NEWCONFIG
edit_dpdk_config CONFIG_RTE_TEST_PMD=n $NEWCONFIG
edit_dpdk_config CONFIG_RTE_IXGBE_INC_VECTOR=n $NEWCONFIG
eidt_dpdk_config CONFIG_RTE_SCHED_COLLECT_STATS=y $NEWCONFIG
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix a typo eidt -> edit

@ynkjm
Copy link

ynkjm commented May 9, 2016

Hi @eugene-che

Thank you for queue improvement pull request.
Your pull request looks good but several modifies are required for merge.

  • Could you modify several single if conditional to be put on a separate line?
  • Could you fix a typo (eidt -> edit)?

The following make option is very useful for checking the syntax and make code more beautiful with our coding style.

$ make beautify

thanks!

@eugene-che
Copy link
Author

Hi @ynkjm

Thanks for the review!
I have updated the patch to meet your suggestions.

@ynkjm
Copy link

ynkjm commented May 13, 2016

Hi @eugene-che

Thanks you for your modification.
I will check it in our lab.

@ynkjm
Copy link

ynkjm commented May 16, 2016

Hi @eugene-che

We have checked your patch in our lab. We found some unit test errors.
I'm try to investigate these unit test errors.

@ynkjm ynkjm added this to the Release 0.2.8 milestone May 17, 2016
@ynkjm ynkjm self-assigned this May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ynkjm ynkjm

Labels
Under review
Projects
None yet
Milestone
Release 0.2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@eugene-che @ynkjm