fix(langchain): improve output parsing in xml agent #3975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jacoblee93
reviewed
Jan 14, 2024
jacoblee93
reviewed
Jan 14, 2024
|
Hello. Could you please let me know if there are any plans to complete this pull request soon? I'm currently encountering the issue where closing tags end up in the result as well. It would be greatly appreciated if this fix could be included in the update. If you're short on time, would it be possible for me to create a pull request myself? For instance, I could take the implementation from the Python version: https://api.python.langchain.com/en/latest/_modules/langchain/agents/output_parsers/xml.html#XMLAgentOutputParser |
|
Hey @VishulaKnow, will take it over! |
Fixed posible nulls in the function
|
Sorry it took so long to get this merged, and thanks for the contribution @jmlon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problem with handling of closing XML tags.
Fixed posible nulls returned by the match function.