feat(text_splitters): Add SemanticChunker splitter #7855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Thanks for this! Will give it a look tomorrow. |
jacoblee93
reviewed
Mar 30, 2025
libs/langchain-community/src/experimental/text_splitters/semantic_chunker.ts
Outdated
Show resolved
Hide resolved
libs/langchain-community/src/experimental/text_splitters/semantic_chunker.ts
Outdated
Show resolved
Hide resolved
libs/langchain-community/src/experimental/text_splitters/semantic_chunker.ts
Outdated
Show resolved
Hide resolved
|
Thanks for the comments. All addressed. I'll work on unit tests next |
|
Anxiously awaiting the merge of this 😅 hit me up if you want me to take a crack at the unit tests! |
|
@jacoblee93 unit tests have been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
SemanticChunkerText Splitter from python to Javascript: https://github.com/langchain-ai/langchain-experimental/blob/main/libs/experimental/langchain_experimental/text_splitter.pyTwitter / X: CoDanny