Skip to content

fix(aws): Merge consecutive messages correctly in ChatBedrockConverse #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

fix(aws): Merge consecutive messages correctly in ChatBedrockConverse #7978

merged 2 commits into from
Apr 28, 2025
+83 −1

Conversation

michaelnchin
Copy link
Contributor

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 8, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 28, 2025 10:26pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Apr 28, 2025 10:26pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Apr 8, 2025
@michaelnchin michaelnchin mentioned this pull request Apr 8, 2025
Closed
@jacoblee93 jacoblee93 requested a review from ccurme April 17, 2025 01:00
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Apr 18, 2025
@benjamincburns benjamincburns changed the title aws[patch]: Merge consecutive messages in ChatBedrockConverse fix(aws): Merge consecutive messages correctly in ChatBedrockConverse Apr 28, 2025
@benjamincburns
Copy link
Collaborator

Thanks for the contribution @michaelnchin!

@benjamincburns benjamincburns merged commit 4643965 into langchain-ai:main Apr 28, 2025
23 of 24 checks passed
benjamincburns added a commit that referenced this pull request Apr 30, 2025
@benjamincburns
Revert "fix(aws): Merge consecutive messages correctly in ChatBedrock…
d9964d7 
…Converse (#7978)"

This reverts commit 4643965.
@benjamincburns benjamincburns mentioned this pull request Apr 30, 2025
Merged
@benjamincburns
Copy link
Collaborator

@michaelnchin Unfortunately I had to revert this one, as it was causing the build to fail. Not sure why yet, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChatBedrockConverse, ValidationException
3 participants
@michaelnchin @benjamincburns @ccurme