-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(community): Enhance SAP HANA Vector integration with metadata columns, keyword filtering, and internal embeddings #8001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yberber-sap
wants to merge
22
commits into
langchain-ai:main
Choose a base branch
from
yberber-sap:hana-langchainjs-alignment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Co-authored-by: wsvoja <120735101+wsvoja@users.noreply.github.com>
Co-authored-by: wsvoja <120735101+wsvoja@users.noreply.github.com>
Co-authored-by: wsvoja <120735101+wsvoja@users.noreply.github.com>
…rnal embedding example Co-authored-by: wsvoja <120735101+wsvoja@users.noreply.github.com>
e60316d
to
785502b
Compare
Hi @jacoblee93 👋 Can you take a look at this PR? I'd appreciate your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:enhancement
A large net-new component, integration, or chain. Use sparingly. The largest features
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the SAP HANA Cloud Vector Store integration in
langchainjs
with three major features that align its behavior with the existing Python implementation:Enhancements
Dedicated Metadata Columns
Metadata fields can now be stored in dedicated table columns in addition to the JSON metadata field. This enables more efficient filtering and indexing, and mirrors the behavior of the Python implementation (
add_texts
inhanavector.py
).Keyword Search Filtering
Added support for a
$contains
operator in metadata filters, which constructs SQL full-text search conditions such as:When filtering on fields stored in the JSON metadata, a
WITH
clause is used to project the relevant key into its own column.Internal Embedding Support
Introduced a
HanaInternalEmbeddings
class that uses SAP HANA's nativeVECTOR_EMBEDDING
function to compute document and query embeddings directly in the database. This allows fully in-database similarity search with reduced external dependencies.Depending on whether internal or external embeddings are used, the query structure dynamically switches between injecting a precomputed vector (via
embedQuery()
) or calling the native HANAVECTOR_EMBEDDING
function inline.Tests & Documentation
langchainjs
SAP HANA Vector Store in alignment with the external LangChain Integration Package - Python.Issue: No associated issue.
Dependencies: No new dependencies were introduced in this PR.
Twitter handle: @sapopensource