[12.x] Clarify where the code should be placed #10423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use the same tone that we are used in that section example: // In our middleware...
Context::add('url', $request->url());
Context::add('trace_id', Str::uuid()->toString());
// In our controller...
ProcessPodcast::dispatch($podcast); |
shaedrich
reviewed
May 21, 2025
context.md
Outdated
| @@ -227,6 +227,7 @@ Stacks can be useful to capture historical information about a request, such as | |||
| use Illuminate\Support\Facades\Context; | |||
| use Illuminate\Support\Facades\DB; | |||
|
|
|||
| // In our service provider... | |||
There was a problem hiding this comment.
Or you could use the filename code fence attribute:
```php filename=app/Providers/AppServiceProvider.php
use Illuminate\Support\Facades\Context;
use Illuminate\Support\Facades\DB;
DB::listen(function ($event) {
Context::push('queries', [$event->time, $event->sql]);
});
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The original example lacks context about where the
DB::listenlogic is expected to live, which may confuse developers unfamiliar with the typical usage patterns.Proposed Fix
Add a comment to clarify that the
DB::listencode should be placed in a service provider.Reasoning
This small change improves readability by helping readers understand where the code belongs within a typical Laravel application structure.