Skip to content
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

Switch to vinyl-map2 #679

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Switch to vinyl-map2 #679

merged 1 commit into from
Nov 6, 2016

Conversation

dciancu
Copy link
Contributor

@dciancu dciancu commented Nov 1, 2016

vinyl-map seems to be unmaintained and it creates npm errors.

└─┬ laravel-elixir@6.0.0-11
  └─┬ vinyl-map@1.0.1
    ├── bl@0.7.0
    └── UNMET PEER DEPENDENCY stream-browserify@*

npm ERR! peer dep missing: stream-browserify@*, required by bl@0.7.0

I tried to run tests, but the command fails:

$ npm test

> laravel-elixir@6.0.0-11 test /tmp/elixir
> cd elixir-test-app && mocha --require babel-core/register --require=test/bootstrap.js

module.js:442
    throw err;
    ^

Error: Cannot find module 'laravel-elixir'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/tmp/elixir/elixir-test-app/test/bootstrap.js:1:1)
    at Module._compile (module.js:541:32)
    at loader (/tmp/elixir/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/tmp/elixir/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at /tmp/elixir/node_modules/mocha/bin/_mocha:311:3
    at Array.forEach (native)
    at Object.<anonymous> (/tmp/elixir/node_modules/mocha/bin/_mocha:310:10)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3
npm ERR! Test failed.  See above for more details.

vinyl-map seems to be unmaintained and it creates npm errors.
@dciancu
Copy link
Contributor Author

dciancu commented Nov 1, 2016

Also makes it unable to shrinkwrap dependencies.

npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/Cellar/node/6.3.1/bin/node" "/usr/local/bin/npm" "shrinkwrap"
npm ERR! node v6.3.1
npm ERR! npm  v4.0.1

npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! peer invalid: stream-browserify@*, required by bl@0.7.0
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /tmp/test/npm-debug.log

@JeffreyWay JeffreyWay merged commit 555042b into laravel:master Nov 6, 2016
@JeffreyWay
Copy link
Contributor

Thanks!

dongyukang pushed a commit to dongyukang/laravel that referenced this pull request Dec 2, 2016
Bumped version for laravel-elixir to 6.0.0-14 in which various npm errors and warnings have been fixed (laravel/elixir#679).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants